Monkey patched two Rich functions. #1501
Merged
+345
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 23 23
Lines 4927 4955 +28
=======================================
+ Hits 4867 4895 +28
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Rich's Text.from_ansi(). Now a dev isn't required to call a cmd2-specific function to get the bug fix. Monkey patched Rich's Segment.apply_style() to fix an issue where background colors incorrectly carry over onto the following line when printing with soft_wrap enabled.
kmvanbrunt
force-pushed
the
patch_rich
branch
from
f966e51 to
fad918a
Compare
tleonhardt
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
rich_utils.string_to_rich_text()in favor of monkey patching Rich'sText.from_ansi(). Now a dev isn't required to call a cmd2-specific function to get the bug fix.Monkey patched
Rich's Segment.apply_style()to fix an issue where background colors incorrectly carry over onto the following line when printing with soft_wrap enabled.